Add SingleOps.__round__ and optimizations in Builtin.round.#2074
Open
mickp wants to merge 1 commit into
Open
Conversation
Testing === ``` >>> import System >>> v = 987.654321 >>> assert round(System.Double(v)) == round(System.Single(v)) >>> print(round(System.Double(v), 3), round(System.Single(v), 3)) 987.654 987.654 ``` (Attempted to add assertions in tests/suite/test_builtinfunc.py, but attempting to run fails with ``` RUNNING IRONPYTHON TESTS USING THESE FLAGS: Traceback (most recent call last): File "run.py", line 330, in <module> File "run.py", line 295, in runTest File "run.py", line 241, in runTestSlow File "run.py", line 226, in run_one_command AttributeError: 'module' object has no attribute 'popen3' ``` ) ```
Author
|
I attempted to add assertions in tests/suite/test_builtinfunc.py, but I can't get those tests to run: they fail with |
Contributor
|
Thanks for the PR. I think it generally seems fine. I won't have time to properly review/test this for a couple weeks, but I'll get around to it as soon as I can. Not sure why the test changes aren't working. I've been doing some structural changes recently so I may be to blame... So I don't forget... I want to check are how it compares to "prior art" such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing